Polymorphism improvements #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leo-naeka thanks for doing this, looks like you may have solved some of the issues (like pulling out a generic polymorphic serializer and maybe solving the django <= 1.7 issue). What sort of tests do you suggest for it? |
|
Hey @ograycode, what's up about this? |
|
@leo-naeka I wasn't sure if you were done with it or not. |
|
@ograycode Everything may not be completely finished, but at this time, I suppose the best approach is to get some feedback from people awaiting this upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK @ograycode, so here are some improvements.
My goal was to clearly separate regular and polymorphic serializers, as well as regular and polymorphic relations.
The downside of this is that serializers polymorphic relations requires to be explicitly declared (at this time) and this can be... quite verbose (see example/serializers.py#L117-L118)...
This definitely needs some extra tests and above all, documentation.
I let you play with that, keep me informed!