Skip to content

[pull] master from phishman3579:master #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 435 commits into
base: master
Choose a base branch
from

Conversation

pull[bot]
Copy link

@pull pull bot commented Jun 25, 2019

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

phishman3579 and others added 30 commits September 2, 2016 11:09
Hi Justin, I'm a big fan of your code, but, I think I may have spotted an issue in your add method for ArrayList. When the index of the element that you want to insert is smaller than the size of the list, you shift the array down one spot and insert the value at the desired position. However, I think you forgot to increase the size of the list after that, which may cause some problems when iterating through the arrayList.
KMP == Knuth–Morris–Pratt
@pull pull bot added the ⤵️ pull label Jun 25, 2019
@pull pull bot added the merge-conflict Resolve conflicts manually label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull merge-conflict Resolve conflicts manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.