Skip to content

Add support to fetch purl #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 7, 2025
Merged

Add support to fetch purl #179

merged 6 commits into from
Aug 7, 2025

Conversation

TG1999
Copy link
Collaborator

@TG1999 TG1999 commented Aug 6, 2025 •
edited
Loading

fixes: aboutcode-org/scancode.io#1383

The API design would look something like this

>>> from fetchcode import fetch
>>> resp = fetch("pkg:pypi/requests@2.31.0")

@TG1999
Add support to fetch purl
ac68acb 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 mentioned this pull request Aug 6, 2025
Closed
@TG1999
Fix purl scheme
299d366 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
tdruez
tdruez requested changes Aug 6, 2025
View reviewed changes
Copy link

@tdruez tdruez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. Also there's a lack of unit test for this code.

TG1999 added 2 commits August 6, 2025 14:08
@TG1999
Address review comments
0838daf 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Add tests
02b9671 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
tdruez
tdruez requested changes Aug 7, 2025
View reviewed changes
Copy link

@tdruez tdruez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage is too light, it does not cover properly the new code.
Also, the mocking is not ideal.

Lastly, that new PURL support should be documented, and probably displayed in the README

TG1999 added 2 commits August 7, 2025 14:41
@TG1999
Address review comments
9682dac 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Fix README indentation
56156b0 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
tdruez
tdruez approved these changes Aug 7, 2025
View reviewed changes
Copy link

@tdruez tdruez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for merge.

@TG1999 TG1999 merged commit 92dedc8 into master Aug 7, 2025
9 checks passed
@TG1999 TG1999 deleted the add_support_to_fetch_purl branch August 7, 2025 09:26
@TG1999 TG1999 mentioned this pull request Aug 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdruez tdruez tdruez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use PURL for inputs
2 participants
@TG1999 @tdruez