-
-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alpine url bug fix and AGPL License version issue #3744
Open
404-geek
wants to merge
6
commits into
aboutcode-org:develop
Choose a base branch
from
404-geek:404-geek_develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cc3bfdc
update http alpine package vcs url to https:// nexB#3731
404-geek 97bc749
modifed rule to be strictly about AGPL nexB#3740
404-geek ec7b8f1
changed `test_pdf.py` numbered_text_lines failed test case due to reg…
404-geek 2dcb52f
Merge branch 'nexB:develop' into 404-geek_develop
404-geek c2de63c
modified test_pdf numbered_text_lines
404-geek d4edf25
changed http to https for test jsons nexB#3731
404-geek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
src/licensedcode/data/rules/agpl-3.0-plus_or_commercial-license_4.RULE
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the change is correct note that the rule filenames reflect the license-expression of the rule and a change in the license-expression needs to happen like this:
is_deprecated
attributescancode-reindex-licenses
(This will remove the deprecated rule from the index so you can add a new one, otherwise two rules with the same text cannot exist in the index)agpl-3.0-plus
and add notes about the origin, that this was previously the src/agpl-3.0-plus_or_commercial-license_4.RULE
rule. Add the issue reference in the commit. (You can paste the rule content atetc/scripts/licenses/buildrules-template.txt
and then runpython etc/scripts/licenses/buildrules.py etc/scripts/licenses/buildrules-template.txt
in an activated virtualenv, and this will create the rule automatically, with the appropriate filename)