Revert back to require for use in templates #1320
Conversation
|
|
I'm not sure if this warrants a minor version bump or if patch is acceptable |
|
@smorimoto could you please have a look when you get the chance? |
There was a problem hiding this comment.
Pull Request Overview
This PR restores synchronous require calls in templates by reverting recent changes that replaced require with async import.
- Removed
asyncfromrequireFnFromTemplate - Replaced
await import(...)withrequire(...)for both file paths and package names
Comments suppressed due to low confidence (4)
src/templates-worker.ts:77
- Consider updating any JSDoc or TypeScript signatures to reflect that this function is now synchronous rather than returning a Promise.
requireFnFromTemplate = (packageOrPath: string) => {
src/templates-worker.ts:82
- Using
requireon an ES module may yield an object with adefaultproperty. You might want to returnmodule.default ?? moduleto handle both CJS and ESM modules correctly.
return require(
src/templates-worker.ts:91
- [nitpick] For packages that resolve to ESM, consider using
createRequirefrom Node'smoduleAPI or adding tests to confirm that requiring works as expected in both CJS and ESM contexts.
return require(packageOrPath);
This PR aimed to remove
requirein favour ofimport.A side effect of this was that
requireno longer works correctly inside templates because it is now an async function. Since the template is rendered synchronously, it is no longer possible to import anything from inside a template.This PR restores that functionality, which was introduced in version 4.0.4.
Thanks!