-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache-Hit set to string, not boolean, as of v4.1.0 #1466
Comments
I'm seeing the same bad behavior.
|
This is cause by #1404, which was a major breaking change. |
It also breaks https://github.com/AnimMouse/setup-rclone, see AnimMouse/setup-rclone#10 |
It's sad that it's 2024, and GitHub Actions still can't make their type system right! |
This should be fixed in https://github.com/actions/cache/releases/tag/v4.1.1, the |
@joshmgross, |
Maintainers, you're doing quite well job. I'm not being sarcastic. Pray for your mental safety. The behavior change was intentional to make it consistent with the documentation. The outputs of GitHub Actions have never supported booleans. You shoud check against a string It was an regression that the output is not set in v4. Yes, the behavior change was intentional to fixing the regression. In v3, The changes are reverted right now, but the ternary output is quite difficult IMHO. Well, engineering is difficult. |
@itchyny I agree that using Our priority is to maintain the existing behavior and avoid unnecessary user friction. The existing
In the future, I'd like to break that up into two outputs so that we don't need this odd ternary string to represent all 3 cases. Ideally that would come with proper support in the Actions runner for typed outputs, but that's not currently on our roadmap. Alternatively, we adopt the changes that were reverted and properly release that as a breaking change with a I'm going to call this closed for now, but I'm open to further feedback on how we can improve |
After a recent upgrade, our runners started behaving differently on cache miss.
As of 0c45773, a step defined with
if: steps.cache-release.outputs.cache-hit
would be skipped if the "cache release" job missed the cache, as intended. As of 2cdf405, the job now runs on cache miss, despite clearly missing the cache.Here's a relevant snippet of the run with debug logging enabled
The text was updated successfully, but these errors were encountered: