Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise isGhes logic #1474

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Revise isGhes logic #1474

merged 4 commits into from
Oct 22, 2024

Conversation

jww3
Copy link
Contributor

@jww3 jww3 commented Oct 18, 2024

Description

I'm fixing the logic within helper method isGhes to ensure that it doesn't misrecognize GitHub Enterprise Cloud instances as GHES instances.

Motivation and Context

https://github.com/newsroom/press-releases/data-residency-in-the-eu

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jww3 jww3 marked this pull request as ready for review October 18, 2024 16:25
@jww3 jww3 requested a review from a team as a code owner October 18, 2024 16:25
@Link- Link- merged commit 9803087 into main Oct 22, 2024
16 checks passed
@Link- Link- deleted the jww3-isghes-fix branch October 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants