Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 7 commits
- 29 files changed
- 4 contributors
Commits on Oct 6, 2023
-
test: integration tests for
main.js(#56)Part of #43 This PR adds tests for [`main.js`](https://github.com/actions/create-github-app-token/blob/main/lib/main.js), similar to [the tests that already exist for `post.js`](https://github.com/actions/create-github-app-token/tree/main/tests). Specifically, it tests that: - `main` exits with an error when `GITHUB_REPOSITORY` is missing. - `main` exits with an error when `GITHUB_REPOSITORY_OWNER` is missing. - `main` successfully obtains a token when… - …the `owner` and `repositories` inputs are set (and the latter is a single repo). - …the `owner` and `repositories` inputs are set (and the latter is a list of repos). - …the `owner` input is set (to an org), but the `repositories` input isn’t set. - …the `owner` input is set (to a user), but the `repositories` input isn’t set. - …the `owner` input is not set, but the `repositories` input is set. - …neither the `owner` nor `repositories` input is set. ❧ Architecturally, in order to keep individual tests concise, this PR adds `tests/main.js`, which: - sets commonly-used inputs, environment variables, and mocks, then - calls a callback function that can edit the variables and add additional mocks, then - runs `main.js` itself. The `tests/main-token-get-*.test.js` test files run `tests/main.js` with various scenario-specific callback functions.
-
-
feat: use dash notation for inputs (deprecates underscore notation) (#59
) Fixes #57 This PR implements the 3-step plan proposed by @gr2m in #57 (comment): > 1. Support both input types > 2. Log a deprecation warning for the old notation > 3. Add a test for deprecations Although this PR supports both input formats simultaneously, I opted _not_ to document the old format in the updated README. That’s a decision I’m happy to revisit, if y’all would prefer to have documentation for both the old and new formats.
-
docs: update
skip-token-revokeinput name (#61)This is a quick follow-up to #59. I was mid-review when it merged and noticed one instance of `skip_token_revoke` in the README that didn't get changed to `skip-token-revoke`. The PR merged just before I pushed a commit to fix it.
-
ci(release): use local version (#60)
follow up to #59 (comment) --------- Co-authored-by: Parker Brown <17183625+parkerbxyz@users.noreply.github.com>
-
build(release): 1.5.0 [skip ci]
# [1.5.0](v1.4.0...v1.5.0) (2023-10-06) ### Features * use dash notation for inputs (deprecates underscore notation) ([#59](#59)) ([7b1d2ae](7b1d2ae)), closes [#57](#57) [/github.com//issues/57#issuecomment-1751272252](https://github.com//github.com/actions/create-github-app-token/issues/57/issues/issuecomment-1751272252)
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.4.0...v1.5.0