Skip to content

docs(README): fix use of deprecated arguments #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

docs(README): fix use of deprecated arguments #86

merged 1 commit into from
Dec 5, 2023

Conversation

steverusso
Copy link
Contributor

@steverusso steverusso commented Dec 5, 2023 •
edited
Loading

Using those fields that have an underscore (instead of a hyphen) cause the following warnings if used:

Warning: Input 'app_id' has been deprecated with message: 'app_id' is deprecated and will be removed in a future version. Use 'app-id' instead.
Warning: Input 'private_key' has been deprecated with message: 'private_key' is deprecated and will be removed in a future version. Use 'private-key' instead.

So this PR just drops the last use of app_id and private_key from the README in favor of app-id and private-key.

@steverusso steverusso requested review from gr2m, parkerbxyz and a team as code owners December 5, 2023 16:26
gr2m
gr2m approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 💐

@gr2m gr2m changed the title docs: fix use of deprecated fields in readme docs(README): fix use of deprecated arguments Dec 5, 2023
@gr2m gr2m merged commit 8746053 into actions:main Dec 5, 2023
@create-app-token-action-releaser
Copy link

🎉 This PR is included in version 1.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@parkerbxyz parkerbxyz Awaiting requested review from parkerbxyz

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steverusso @gr2m