-
Notifications
You must be signed in to change notification settings - Fork 456
Expose all actions toolkit packages #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like I would need to add some more licenses to satisfy licensed. I don't want to clutter up this PR unnecessarily so I can add the missing licenses once/if you're open to merging this in. |
Is there a workaround to use the other packages without this PR? |
You might be able to |
👋 Thanks for the submission @MatisseHack. I'm a little concerned about the significant increase in this action's size from including all of these packages. Is there a specific use case for each of these? For packages like |
True, it does increase the size by several factors. Would minifying be enough to assuage your concerns? That gets the 2.5 MB file down to 1.1 MB. Still larger than the original 210 KB file, but maybe within reason? I actually only want access to the That being said, I don't have any personal need for those two packages at the moment so I'm open to removing them if needed. |
@MatisseHack Could we only add |
Forgot to mention this in the PR description, but part of the motivation behind using a namespace was to eventually simplify the script parameters to just: But obviously that would be a breaking change, which also makes a bit less sense if the I went ahead and created #127 with just the globbing package added. |
Yeah I can definitely see how that would be confusing 😅 Going to close this PR out, I've merged #127 and release a new version soon |
Some toolkit packages are already individually passed to the script as arguments (
@actions/core
and@actions/io
), but there are additional toolkit packages that could be helpful when writing scripts.This PR adds all toolkit modules to an
actions
module that is then passed to the script. To use the@actions/exec
module, one could simply write: