-
Notifications
You must be signed in to change notification settings - Fork 123
Add Support for Linux arm64 Builds #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Linux arm64 Builds #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR closes #230
That being said, neither pull requests fix the issue.
Either you need to be cross building on x86_64 which would require much more changes to the builder script or you need to build on an aarch64 runner (you might have access through the private beta but as everything is private, I don't even know what's provided).
In order to test, again, you either need an aarch64 runner or update the tests scripts to run with qemu on an x86_64 runner.
Gotta wait for https://github.blog/changelog/2023-10-30-accelerate-your-ci-cd-with-arm-based-hosted-runners-in-github-actions/ Should have been Q1 2024, but we don't seem to be there yet 🤔 |
It's should be a private BETA for now so not everyone can use/see that - I know I don't - (or is it not ready ?). At least, it seems they now do have access to some ubuntu 22.04 aarch64 runners: https://github.com/actions/python-versions/actions/runs/9254745717 |
I think it should be good to release now? We are blocked on ubuntu-arm python package too. |
I got an email from GitHub about this, but IIRC arm64 builders have only been enabled for organisations and not individuals? I’ll try to validate this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, though admittedly I didn't run it myself.
I still get the following.
And sure enough, I still only see ARM builds for Darwin in versions-manifest.json. Is there additional work required to use these changes and build for ubuntu/arm64? |
Ah, it looks like #289 will resolve. |
This Pull Request introduces changes to enable building of Python packages for Linux arm64 architecture.