Make eslint-compact matcher compatible with Stylelint #98

FloEdelmann · 2019-12-27T23:10:05Z

Stylelint has a compact formatter that is (nearly) compatible with ESLint one's.

It outputs lowercase severity strings though, so eslint-compact matcher's RegExp is not triggered.

This PR changes the matcher to also match lowercase severity strings.

Alternatively, the matcher could be duplicated as stylelint-compact and both RegExps could target exact lowercase/uppercase severities.

Example check run containing Stylelint output: https://github.com/OpenLightingProject/open-fixture-library/pull/1163/checks?check_run_id=365592295

ViniciusFXavier

👍

ybiquitous · 2020-04-10T07:16:08Z

I really want this update! 🙏

bryanmacfarlane · 2021-01-20T17:01:53Z

any interest in updating PR to target main instead of master?

FloEdelmann · 2021-01-20T19:48:58Z

@bryanmacfarlane Done 👌

Jimimaku · 2022-11-21T22:39:13Z

Stylelint has a compact formatter that is (nearly) compatible with ESLint one's.

It outputs lowercase severity strings though, so eslint-compact matcher's RegExp is not triggered.

This PR changes the matcher to also match lowercase severity strings.

Alternatively, the matcher could be duplicated as stylelint-compact and both RegExps could target exact lowercase/uppercase severities.

Example check run containing Stylelint output: https://github.com/OpenLightingProject/open-fixture-library/pull/1163/checks?check_run_id=365592295

[Fix] Creating sandbox from recipe with CPCode is not using provided CPCode

szepeviktor · 2024-02-29T12:28:16Z

Friendly ping 🏓

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.3.0 to 4.4.0. Release notes *Sourced from [actions/setup-node's releases](https://github.com/actions/setup-node/releases).* > v4.4.0 > ------ > > What's Changed > -------------- > > ### Bug fixes: > > * Make eslint-compact matcher compatible with Stylelint by [`@FloEdelmann`](https://github.com/FloEdelmann) in [actions/setup-node#98](https://redirect.github.com/actions/setup-node/pull/98) > * Add support for indented eslint output by [`@fregante`](https://github.com/fregante) in [actions/setup-node#1245](https://redirect.github.com/actions/setup-node/pull/1245) > > ### Enhancement: > > * Support private mirrors by [`@marco-ippolito`](https://github.com/marco-ippolito) in [actions/setup-node#1240](https://redirect.github.com/actions/setup-node/pull/1240) > > ### Dependency update: > > * Upgrade `@action/cache` from 4.0.2 to 4.0.3 by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-node#1262](https://redirect.github.com/actions/setup-node/pull/1262) > > New Contributors > ---------------- > > * [`@FloEdelmann`](https://github.com/FloEdelmann) made their first contribution in [actions/setup-node#98](https://redirect.github.com/actions/setup-node/pull/98) > * [`@fregante`](https://github.com/fregante) made their first contribution in [actions/setup-node#1245](https://redirect.github.com/actions/setup-node/pull/1245) > * [`@marco-ippolito`](https://github.com/marco-ippolito) made their first contribution in [actions/setup-node#1240](https://redirect.github.com/actions/setup-node/pull/1240) > > **Full Changelog**: <actions/setup-node@v4...v4.4.0> Commits * [`49933ea`](actions/setup-node@49933ea) Bump `@action/cache` from 4.0.2 to 4.0.3 ([#1262](https://redirect.github.com/actions/setup-node/issues/1262)) * [`e3ce749`](actions/setup-node@e3ce749) feat: support private mirrors ([#1240](https://redirect.github.com/actions/setup-node/issues/1240)) * [`40337cb`](actions/setup-node@40337cb) Add support for indented eslint output ([#1245](https://redirect.github.com/actions/setup-node/issues/1245)) * [`1ccdddc`](actions/setup-node@1ccdddc) Make eslint-compact matcher compatible with Stylelint ([#98](https://redirect.github.com/actions/setup-node/issues/98)) * See full diff in [compare view](actions/setup-node@cdca736...49933ea) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/setup-node&package-manager=github\_actions&previous-version=4.3.0&new-version=4.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

* Fix macos latest check failures (actions#1041) * Update latest node versions * Update latest node versions * Update test data * Update test data * Update test data * Update test data * Update test data * macos lts failure fix * Update macos-13 * Bump braces from 3.0.2 to 3.0.3 (actions#1087) * Bump braces from 3.0.2 to 3.0.3 Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Bump undici from 5.28.3 to 5.28.4 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com> * Documentation update in the README file (actions#1106) * first commit on using setup node * Delete .github/workflows/helloWorld.yml * Create main.yml * Rename main.yml to helloworld.yml * goodbye world added * name changed to goodbye * updated README --------- Co-authored-by: Suyash Gaonkar <39784472+suyashrg18@users.noreply.github.com> * Fix: windows arm64 setup (actions#1126) * Add condition to ensure ZIP extraction targets only Windows ARM64 official archives * Bumps micromatch from 4.0.5 to 4.0.8 * Create publish-immutable-action.yml * Upgrade IA Publish * Correct version string (actions#1124) * Resolve High Security Alerts by upgrading Dependencies (actions#1132) * db-alerts-fix * npm run format * db-alert-fix * failure check fix * check- filaure fix * Revise `isGhes` logic (actions#1148) * Revise `isGhes` logic * ran 'npm run format' * added unit test * fix: add arch to cached path (actions#843) * fix: add arch to cached path * fix: change from using env to os module * fix: use process.env.RUNNER_OS instead of os.platform() * fix: remove unused var * Add macos-13 to the workflows and upgrade publish-actions from 0.2.2 to 0.3.0 (actions#1174) * Update versions.yml * Update versions.yml * ubuntu-24, macos-13 updates * check -failure fix * Update README.md (actions#1193) * Create dependabot.yml (actions#1192) * Use the new cache service: upgrade `@actions/cache` to `^4.0.0` (actions#1191) * upgrade `@actions/cache` to `^4.0.0` * Review licenses & update types * updated package-lock.json * Bump pnpm/action-setup from 2 to 4 (actions#1194) Bumps [pnpm/action-setup](https://github.com/pnpm/action-setup) from 2 to 4. - [Release notes](https://github.com/pnpm/action-setup/releases) - [Commits](pnpm/action-setup@v2...v4) --- updated-dependencies: - dependency-name: pnpm/action-setup dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 (actions#1195) Bumps [actions/publish-immutable-action](https://github.com/actions/publish-immutable-action) from 0.0.3 to 0.0.4. - [Release notes](https://github.com/actions/publish-immutable-action/releases) - [Commits](actions/publish-immutable-action@0.0.3...v0.0.4) --- updated-dependencies: - dependency-name: actions/publish-immutable-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump semver from 7.6.0 to 7.6.3 (actions#1196) * Bump semver from 7.6.0 to 7.6.3 Bumps [semver](https://github.com/npm/node-semver) from 7.6.0 to 7.6.3. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.6.0...v7.6.3) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * fix for check-dist & license check failures --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com> * Bump @types/jest from 29.5.12 to 29.5.14 (actions#1201) Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 29.5.12 to 29.5.14. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump undici from 5.28.4 to 5.28.5 (actions#1205) * Bump undici from 5.28.4 to 5.28.5 Bumps [undici](https://github.com/nodejs/undici) from 5.28.4 to 5.28.5. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.4...v5.28.5) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * fix for check-dist and license failures * npm run updates --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com> * Bump @actions/glob from 0.4.0 to 0.5.0 (actions#1200) * Bump @actions/glob from 0.4.0 to 0.5.0 Bumps [@actions/glob](https://github.com/actions/toolkit/tree/HEAD/packages/glob) from 0.4.0 to 0.5.0. - [Changelog](https://github.com/actions/toolkit/blob/main/packages/glob/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/glob) --- updated-dependencies: - dependency-name: "@actions/glob" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix for check-dist and license failures --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com> * actions/cache upgrade (actions#1251) Co-authored-by: “gowridurgad” <“hgowridurgad@github.com> * Bump @vercel/ncc from 0.38.1 to 0.38.3 (actions#1203) * Bump @vercel/ncc from 0.38.1 to 0.38.3 Bumps [@vercel/ncc](https://github.com/vercel/ncc) from 0.38.1 to 0.38.3. - [Release notes](https://github.com/vercel/ncc/releases) - [Commits](vercel/ncc@0.38.1...0.38.3) --- updated-dependencies: - dependency-name: "@vercel/ncc" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * fix for check failures --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com> * Bump @actions/tool-cache from 2.0.1 to 2.0.2 (actions#1220) * Bump @actions/tool-cache from 2.0.1 to 2.0.2 Bumps [@actions/tool-cache](https://github.com/actions/toolkit/tree/HEAD/packages/tool-cache) from 2.0.1 to 2.0.2. - [Changelog](https://github.com/actions/toolkit/blob/main/packages/tool-cache/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/tool-cache) --- updated-dependencies: - dependency-name: "@actions/tool-cache" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * check failures fix --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com> * Make eslint-compact matcher compatible with Stylelint (actions#98) * Add support for indented eslint output (actions#1245) * feat: support private mirrors (actions#1240) * feat: support private mirrors * chore: change fallback message with mirrors * Bump @action/cache from 4.0.2 to 4.0.3 (actions#1262) * Update versions.yml * Update versions.yml * actions/cache upgrade to 4.0.3 * events update * npm audit fix revert * npm adit fix revert * Bump @octokit/request-error and @actions/github (actions#1227) * Bump @octokit/request-error and @actions/github Bumps [@octokit/request-error](https://github.com/octokit/request-error.js) to 5.1.1 and updates ancestor dependency [@actions/github](https://github.com/actions/toolkit/tree/HEAD/packages/github). These dependencies need to be updated together. Updates `@octokit/request-error` from 2.1.0 to 5.1.1 - [Release notes](https://github.com/octokit/request-error.js/releases) - [Commits](octokit/request-error.js@v2.1.0...v5.1.1) Updates `@actions/github` from 5.1.1 to 6.0.0 - [Changelog](https://github.com/actions/toolkit/blob/main/packages/github/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/github) --- updated-dependencies: - dependency-name: "@octokit/request-error" dependency-type: indirect - dependency-name: "@actions/github" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Fix failures --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com> * Bump uuid from 9.0.1 to 11.1.0 (actions#1273) * Bump uuid from 9.0.1 to 11.1.0 Bumps [uuid](https://github.com/uuidjs/uuid) from 9.0.1 to 11.1.0. - [Release notes](https://github.com/uuidjs/uuid/releases) - [Changelog](https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md) - [Commits](uuidjs/uuid@v9.0.1...v11.1.0) --- updated-dependencies: - dependency-name: uuid dependency-version: 11.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump uuid from 9.0.1 to 11.1.0 Bumps [uuid](https://github.com/uuidjs/uuid) from 9.0.1 to 11.1.0. - [Release notes](https://github.com/uuidjs/uuid/releases) - [Changelog](https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md) - [Commits](uuidjs/uuid@v9.0.1...v11.1.0) --- updated-dependencies: - dependency-name: uuid dependency-version: 11.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Fix failures --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com> * fix: build --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: suyashgaonkar <suyashgaonkar@github.com> Co-authored-by: Suyash Gaonkar <39784472+suyashrg18@users.noreply.github.com> Co-authored-by: Priya Gupta <147705955+priyagupta108@users.noreply.github.com> Co-authored-by: Joel Ambass <Jcambass@users.noreply.github.com> Co-authored-by: William Entriken <github.com@phor.net> Co-authored-by: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Co-authored-by: John Wesley Walker III <81404201+jww3@users.noreply.github.com> Co-authored-by: Peng Xiao <pengxiao@outlook.com> Co-authored-by: Ben Wells <benwells@github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com> Co-authored-by: gowridurgad <159780674+gowridurgad@users.noreply.github.com> Co-authored-by: “gowridurgad” <“hgowridurgad@github.com> Co-authored-by: Flo Edelmann <git@flo-edelmann.de> Co-authored-by: fregante <me@fregante.com> Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>

@FloEdelmann

Make eslint-compact matcher compatible with Stylelint

3077533

ViniciusFXavier approved these changes Apr 7, 2020

View reviewed changes

ybiquitous mentioned this pull request Apr 10, 2020

Add new formatter for GitHub Actions stylelint/stylelint#4698

Closed

FloEdelmann mentioned this pull request May 29, 2020

update-pr-from-base-branch sometimes doesn't add the button refined-github/refined-github#3155

Closed

bryanmacfarlane self-assigned this Jan 20, 2021

FloEdelmann changed the base branch from master to main January 20, 2021 19:48

Merge branch 'main' into patch-1

43811dd

FloEdelmann requested a review from a team August 15, 2022 08:36

krzyk pushed a commit to krzyk/setup-node that referenced this pull request Apr 11, 2023

Merge pull request actions#98 from akamai/feature/WEEPKRK-1069

984ea15

[Fix] Creating sandbox from recipe with CPCode is not using provided CPCode

priya-kinthali assigned priya-kinthali and unassigned bryanmacfarlane Mar 21, 2025

priyagupta108 approved these changes Mar 21, 2025

View reviewed changes

priya-kinthali approved these changes Mar 21, 2025

View reviewed changes

aparnajyothi-y approved these changes Mar 21, 2025

View reviewed changes

szepeviktor approved these changes Mar 21, 2025

View reviewed changes

HarithaVattikuti approved these changes Mar 24, 2025

View reviewed changes

HarithaVattikuti merged commit 1ccdddc into actions:main Mar 24, 2025

FloEdelmann deleted the patch-1 branch March 24, 2025 23:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make eslint-compact matcher compatible with Stylelint #98

Make eslint-compact matcher compatible with Stylelint #98

Uh oh!

FloEdelmann commented Dec 27, 2019 •

edited

Loading

Uh oh!

ViniciusFXavier left a comment

Uh oh!

ybiquitous commented Apr 10, 2020

Uh oh!

bryanmacfarlane commented Jan 20, 2021

Uh oh!

FloEdelmann commented Jan 20, 2021

Uh oh!

Jimimaku commented Nov 21, 2022

Uh oh!

szepeviktor commented Feb 29, 2024

Uh oh!

Uh oh!

Make eslint-compact matcher compatible with Stylelint #98

Make eslint-compact matcher compatible with Stylelint #98

Uh oh!

Conversation

FloEdelmann commented Dec 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ViniciusFXavier left a comment

Choose a reason for hiding this comment

Uh oh!

ybiquitous commented Apr 10, 2020

Uh oh!

bryanmacfarlane commented Jan 20, 2021

Uh oh!

FloEdelmann commented Jan 20, 2021

Uh oh!

Jimimaku commented Nov 21, 2022

Uh oh!

szepeviktor commented Feb 29, 2024

Uh oh!

Uh oh!

FloEdelmann commented Dec 27, 2019 •

edited

Loading