Delete downloaded archive after extracting it during install #1090
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR deletes the downloaded Python, PyPy, and GraalPy archives after extraction during installation to prevent unnecessary disk usage and incorrect archiving of the archive files.
- Removed downloaded archive after extraction in install-python.ts
- Removed downloaded archive after extraction in install-pypy.ts
- Removed downloaded archive after extraction in install-graalpy.ts
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/install-python.ts | Added rm import and removed the downloaded archive after extraction |
| src/install-pypy.ts | Added rm import and removed the downloaded archive after extraction |
| src/install-graalpy.ts | Added rm import and removed the downloaded archive after extraction |
Comments suppressed due to low confidence (1)
src/install-python.ts:143
- [nitpick] Consider updating the log message to be consistent with the other installers (e.g., use 'Deleting downloaded archive...' as in install-pypy.ts and install-graalpy.ts).
core.info('Delete downloaded archive');
Since the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
During a Python / Pypy / GraalPy installation, after the downloaded archive is extracted, it is not deleted. This leads to the archive taking up disk space, and often mistakenly getting archived together with the Python version.
This pull request ensures the downloaded archives are deleted after they are extracted and no longer needed.
Check list: