-
Notifications
You must be signed in to change notification settings - Fork 639
Upgrade to node 24 #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade to node 24 #1164
Conversation
Upgrade ot node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Upgrades the Node.js runtime from version 20 to version 24 for a GitHub Action, leveraging runner support for Node 24.
- Updates Node.js runtime specification in GitHub Action configuration
- Upgrades Node.js type definitions to match the new runtime version
- Sets minimum Node.js engine requirement to enforce compatibility
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
File | Description |
---|---|
package.json | Adds Node.js engine requirement and updates @types/node dependency |
action.yml | Changes GitHub Action runtime from node20 to node24 |
.licenses/npm/undici-types.dep.yml | Updates undici-types license tracking for new version |
.licenses/npm/@types/node.dep.yml | Updates @types/node license tracking for new version |
c7178f6
…advanced-usage.md Updated GitHub Actions to use newer versions of checkout and setup-python actions.
Is enforcing node 24 needed for this upgrade to work? |
Hi good question. And my apologies, I'm unsure what you mean by not all popular runners? All the hosted runners at the moment are on 2.238.0. Self-hosted runners should auto-update and if not, then they should be upgraded by the customers eventually. The thing is the actions.yml file targets node24 as well, so it should not be able to run on node 20 because of the actions.yml file. Also this is a major bump, so we could cut a minor version before this 5.0.0 release. |
Upgrade to node 24 since runner release has node 24 support.
Description:
Describe your changes.
Related issue:
Add link to the related issue.
Check list: