Add support for adding a token on GHES to prevent rate limiting #316
Conversation
9d1a2cb to
248abfd
Compare
248abfd to
06ce3b6
Compare
There was a problem hiding this comment.
We've discussed different approaches to this problem. This approach should work, but requiring users to create a PAT in github.com to then use in GHES would create more problems than it would solve.
I think the best approach to unblock you is to fork the action on your GHES instance and apply these changes.
|
What about fixing this for everyone that isn't me then? |
|
The solution implemented in this PR will continue to work exactly as today, for users not setting up til github.com PAT in their GHE project. It will work until they hit a rate limit. This PR provides a solution to that, for those interested. Isn't that to prefer, compared to not have a solution? |
|
It doesn't seem like a common issue so far, but we have thought about it. Having to add a GHES-specific input to an action suggests to me that there's a smoother flow we should look for on the backend. The solution we would like to implement is to make this flow part of GitHub Connect. That would solve the problem in a general way for all first-party actions and be consistent with other flows that fit this pattern. No ETA on this, though. |
|
Hello @brcrista |
|
@Vercasek1985 I recommend forking the action to unblock yourself. As I said above, passing a PAT is a quick fix but not something that we want to support long-term. @HenrikPoulsen I'm going to close this PR since we're not planning on merging it. |
Description:
Adding a new input to specify a token when running on GHES.
When running on GHES today
tokengets thrown away even when explicitly set to be a github.com token.So there is no good way to avoid the rate limiting that would occur.
No idea if this change is idiomatic or not since I don't usually work with typescript.
So let me know if there's any changes you would want me to make.
Related issue:
#229
Check list: