nested has many #2675
nested has many #2675
Conversation
…s block" This reverts commit 77efdba339c1a5f367303487be06c3f6d346660c.
|
I looked at this PR, and while it no longer prematurely breaks out of tags on nested <form>
<fieldset class="inputs" />
<div class="has_many questions">
<fieldset class="inputs has_many_fields" />
<fieldset class="inputs has_many_fields">
<ol>
<li class="input" />
<li class="input" />
<div class="has_many options" />
</ol>
</fieldset>
</div>
<fieldset class="actions" />
</form>So, in I have proposed a new, consistent structure for |
|
I think, in the case of |
|
@shekibobo thanks for playing with this. You are right, I'll try to fix it up at some point over the weekend |
|
superseded by #2679 |
This addresses #2659. It allows for nesting of has_many widgets in inputs & other has_many blocks.
The problem that this fixes is that the has_many widget introduces a extra element into Formtastic's fieldset/ol/li hierarchy, which works fine when the has_many is called at the top level, but breaks when its nested in an inputs block. The reason this happens is that formtastic wraps its fieldsets in an li element when it detects that its already in an inputs block. Formtastic's rationale for this behavior is that if we are in an inputs block, then the parent must an ol element, whose children must be lis. However in the case of a has_many, the parent will be a div.
This patch fixes this behavior by pushing the wrapping li element up around the has_many div instead of the has_many's inputs.
TODO: