Mention Ransack allowlist in documentation #8043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #8043 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 185 185
Lines 4730 4730
=======================================
Hits 4685 4685
Misses 45 45 ☔ View full report in Codecov by Sentry. |
0bcce72 to
fe2320b
Compare
javierjulio
pushed a commit
that referenced
this pull request
Oct 9, 2023
javierjulio
added a commit
that referenced
this pull request
Oct 9, 2023
* Remove link rake task All except for one was to do with whitespace. We want to reduce code footprint and use off-the-shelf tools for basic checks like these. Since they aren't critical we are fine without replacements other than what eslint and rubocop already offer. The sass-rails lint was for webpacker but we have already removed webpacker support. We won't be using any images or asset URLs in the new v4 approach for assets. * Add metadata to activeadmin.gemspec (#8012) * Optimize data generation with insert_all * Mention Ransack allowlist in documentation (#8043) * Update .gitignore * Update all outdated dependencies Ran `bin/bundle update` Ran `yarn upgrade-interactive --latest` Note this updates the default gemfile to use Rails 7.1 but we are good with that for our 3-0-stable branch. --------- Co-authored-by: John DeSilva <desilvjo@umich.edu> Co-authored-by: Francesco Belladonna <francesco@fc5.me>
faizaankhan
pushed a commit
to bugcrowd/activeadmin
that referenced
this pull request
Dec 28, 2023
* Remove link rake task All except for one was to do with whitespace. We want to reduce code footprint and use off-the-shelf tools for basic checks like these. Since they aren't critical we are fine without replacements other than what eslint and rubocop already offer. The sass-rails lint was for webpacker but we have already removed webpacker support. We won't be using any images or asset URLs in the new v4 approach for assets. * Add metadata to activeadmin.gemspec (activeadmin#8012) * Optimize data generation with insert_all * Mention Ransack allowlist in documentation (activeadmin#8043) * Update .gitignore * Update all outdated dependencies Ran `bin/bundle update` Ran `yarn upgrade-interactive --latest` Note this updates the default gemfile to use Rails 7.1 but we are good with that for our 3-0-stable branch. --------- Co-authored-by: John DeSilva <desilvjo@umich.edu> Co-authored-by: Francesco Belladonna <francesco@fc5.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few lines of documentation regarding having to use
ransackable_attributesto enable filteringEnhances #7809
Discussion in PR #8009 (comment)