Bump Formtastic to 5.0 and remove legacy code #8613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
810bd93 to
2cba50c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8613 +/- ##
==========================================
- Coverage 99.11% 99.11% -0.01%
==========================================
Files 141 141
Lines 4076 4073 -3
==========================================
- Hits 4040 4037 -3
Misses 36 36 ☔ View full report in Codecov by Sentry. |
2cba50c to
3acf18c
Compare
|
@tagliala we can't backport this since on v3 we permit Formtastic 3.1+ but I'm fine with this going in for v4. |
Sorry, I was tricked by
Are you fine to bump the dependency to >= 5.0? |
|
@tagliala no worries at all. Right, we'd have to bump here. Yes, I think it would be best to do that bump now on v4. Thanks! |
3acf18c to
8ff0804
Compare
This commit addresses TODO notes in the code related to Formtastic < 4 and sets the minimum required Formtastic version to >= 5.0
8ff0804 to
a9ad8a8
Compare
|
Done, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses TODO notes in the code related to Formtastic < 4
and sets the minimum required Formtastic version to >= 5.0
Confirmed defaults:
Should be also backported to v3