v3: Update dependencies and test against Ruby 3.4 #8614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9d95c5 to
0d58021
Compare
b6e7053 to
05c04b0
Compare
tagliala
commented
Jan 27, 2025
65815c6 to
bfb142c
Compare
Additionally, in order to allow CI to run against all supported
Ruby versions:
- Lock net-imap to ~> 0.4.18 on Rails 6.1
- Lock nokogiri to ~> 1.17.2 on Rails 6.1 and Rails 7.0
- Lock securerandom to ~> 0.3.2 on Rails 6.1 and Rails 7.0
- Do not test Rails 7.1 against Ruby 3.0, change it to the oldest
supported Rails version, 6.1
bfb142c to
08f7867
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8614 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4968
Branches ? 0
=============================================
Hits ? 4928
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. |
tagliala
commented
Jan 27, 2025
| @@ -33,11 +34,17 @@ jobs: | |||
| include: | |||
| - ruby: '3.0' | |||
| os: ubuntu-latest | |||
| deps: rails_71 | |||
| deps: rails_61 | |||
There was a problem hiding this comment.
switched to the oldest supported version (3.0 + 6.1)
tagliala
commented
Jan 27, 2025
| @@ -430,4 +436,4 @@ DEPENDENCIES | |||
| zeitwerk (~> 2.6.18) | |||
|
|
|||
| BUNDLED WITH | |||
| 2.6.2 | |||
| 2.5.23 | |||
There was a problem hiding this comment.
2.6 is not available on Ruby 3.0, this downgrade removes a warning on the CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, in order to allow CI to run against all supported
Ruby versions:
supported Rails version, 6.1