Add and fix existing type hints #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
requested changes
Sep 28, 2022
|
Also, sorry for the merge conflict! Just merged a PR a little bit ago. |
|
Should be ready for final review! |
tekktrik
requested changes
Oct 2, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 3, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_74HC595 to 1.4.1 from 1.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_74HC595#26 from JulianOrteil/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4725 to 1.4.11 from 1.4.10: > Merge pull request adafruit/Adafruit_CircuitPython_MCP4725#22 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.3.9 from 1.3.8: > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#15 from patrickslarson8/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1681 to 1.0.14 from 1.0.13: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1681#10 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA8418 to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#9 from Neradoc/homepage-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #18 and fixes various other existing type hint errors.
Of note, if it is desired, the setters for the
DigitalInOut.directionandDigitalInOut.valueproperties could be removed to save space. Because the docstring already mentions these as being immutable, it would not be wrong to have Python raise anAttributeErrornatively IMO.