Skip to content

Add binascii lib in requirements #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add binascii lib in requirements #9

wants to merge 1 commit into from

Conversation

fgallaire
Copy link
Contributor

No description provided.

@brentru
Copy link
Member

brentru commented Feb 27, 2020

@fgallaire Thanks! just checked to see if we were missing anything else, LGTM!

@brentru brentru closed this Feb 27, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 28, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a5464f8)
d585b42 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ATECC to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_ATECC#9 from fgallaire/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitSPI to 1.0.5 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitSPI#14 from jerryneedell/jerryn_unpack

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.2.0 from 3.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#66 from mytechnotalent/ESP32-MAC-order-library-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 2.1.2 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#26 from kattni/qr-code-update
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#25 from kattni/rename-show
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#24 from kattni/pronoun-badge
sommersoft pushed a commit to sommersoft/Adafruit_CircuitPython_ATECC that referenced this pull request Mar 3, 2020
@brentru
Merge pull request adafruit#9 from fgallaire/master
dd04479 
Add binascii lib in requirements
@tannewt
Copy link
Member

tannewt commented Mar 3, 2020

Why is this needed? binascii is provided by CPython

@fgallaire
Copy link
Contributor Author

hello @tannewt ISTM it's the best way to do it:

  • no import code to change between CPU and MCU versions
  • not relying on two differents libs so no compatibility bug surprises

@tannewt
Copy link
Member

tannewt commented Mar 4, 2020

For 1) we should fix the binascii CircuitPython library to use the same name and 2) ensure they are compatible. There is no reason to have two similar but not compatible things.

@brentru can you take this on?

@fgallaire
Copy link
Contributor Author

fgallaire commented Mar 4, 2020 •
edited
Loading

@tannewt what you propose is

  1. more work to make it work
  2. more risk to make it fail

Is this really necessary as using CircuitPython_binascii just is not a problem ?

@tannewt
Copy link
Member

tannewt commented Mar 5, 2020

While it may be more work now, it isn't more work over the long term. Maintaining two flavors of something is a long term cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgallaire @brentru @tannewt