Skip to content

Example should be renamed to include simpletest #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kattni opened this issue Sep 30, 2019 · 3 comments
Closed

Example should be renamed to include simpletest #11

kattni opened this issue Sep 30, 2019 · 3 comments
Labels
good first issue Good for newcomers

Comments

@kattni
Copy link
Contributor

kattni commented Sep 30, 2019 •
edited
Loading

Example avrprog_read_signature.py should be renamed to avrprog_read_signature_simpletest.py to match CircuitPython library standards.

The lines including this file name in the docs/examples.rst file must also be updated to reflect the name change, e.g.:

.. literalinclude:: ../examples/current_file_name.py
    :caption: examples/current_file_name.py
    :linenos:

would be updated to:

.. literalinclude:: ../examples/current_file_name_changed.py
    :caption: examples/current_file_name_changed.py
    :linenos:
@kattni kattni added the good first issue Good for newcomers label Sep 30, 2019
@abkosar
Copy link
Contributor

abkosar commented Oct 1, 2019

Hey! Can I also do this?

@kattni
Copy link
Contributor Author

kattni commented Oct 1, 2019

Go for it!

@abkosar abkosar mentioned this issue Oct 1, 2019
Merged
@ladyada
Copy link
Member

ladyada commented Oct 1, 2019

donnnnnnne!

@ladyada ladyada closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ladyada @kattni @abkosar