Remove secrets usage #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhalbert there are 6 PRs that use |
dhalbert
requested changes
Feb 25, 2025
Comment on lines
13
to
20
| # file or commit it into Git or other source control. The file dictionary should have the | ||
| # following settings: | ||
| # CIRCUITPY_WIFI_SSID - Your WiFi ssid | ||
| # CIRCUITPY_WIFI_PASSWORD - Your WiFi password | ||
| # device_cert_path - Path to the Device Certificate from AWS IoT ("<THING_NAME>.cert.pem") | ||
| # device_key_path - Path to the RSA Private Key from AWS IoT ("<THING_NAME>.private.key") | ||
| # broker - The endpoint for the AWS IoT broker ("<PREFIX>.iot.<REGION>.amazonaws.com") | ||
| # client_id - The client id. Your device's Policy needs to allow this client ("basicPubSub") |
There was a problem hiding this comment.
Leave out the word "dictionary". You might want to use a format like
... The file should contain the following settings:
CIRCUITPY_WIFI_SSID="your WiFi ssid"
CIRCUITPY_WIFI_PASSWORD="your WiFi password"
...
There was a problem hiding this comment.
Would you then do:
device_cert_path="Path to the Device Certificate from AWS IoT (<THING_NAME>.cert.pem)"
?
There was a problem hiding this comment.
How about:
device_cert_path="THING_NAME.cert.pem" # Path to the Device Certificate from AWS IoT
or, maybe more readable:
# Path to the Device Certificate from AWS IoT
device_cert_path="THING_NAME.cert.pem"
There was a problem hiding this comment.
Okay, I'll move it into triple quotes so it can be copied
dhalbert
reviewed
Feb 25, 2025
Comment on lines
+14
to
+21
| """ | ||
| CIRCUITPY_WIFI_SSID="Your WiFi ssid" | ||
| CIRCUITPY_WIFI_PASSWORD="Your WiFi password" | ||
| device_cert_path="<THING_NAME>.cert.pem" # Path to the Device Certificate from AWS IoT | ||
| device_key_path="<THING_NAME>.private.key" # Path to the RSA Private Key from AWS IoT | ||
| broker="<PREFIX>.iot.<REGION>.amazonaws.com" # The endpoint for the AWS IoT broker | ||
| client_id="client_id" # The client id. Your device's Policy needs to allow this client | ||
| """ |
There was a problem hiding this comment.
This is good but I don't understand why you put it in triple quotes instead of using comments.
There was a problem hiding this comment.
So you can do a direct copy and place it in your settings.toml. Happy to change it back to comments if you prefer
dhalbert
approved these changes
Feb 25, 2025
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 26, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 9.0.1 from 9.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#217 from dhalbert/json-url Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 3.0.0 from 2.0.21: > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#28 from justmobilize/remove-secrets-usage Updating https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core to 4.0.0 from 3.2.13: > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#30 from justmobilize/remove-secrets-usage Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 3.0.0 from 2.6.2: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#66 from justmobilize/remove-secrets-usage Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 3.0.0 from 2.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#20 from justmobilize/remove-secrets-usage Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 2.2.2 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#97 from FoamyGuy/use_ruff_remove_8x_compat Updating https://github.com/adafruit/Adafruit_CircuitPython_WSGI to 3.0.0 from 2.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_WSGI#23 from justmobilize/remove-secrets-usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of secrets and more:
secrets.pytoos.getenvESPSPI_WiFiManagertoWiFiManageradafruit_connection_managerlike all the other examples