Skip to content

Update readme for time sync changes #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

Update readme for time sync changes #51

merged 1 commit into from
Jun 13, 2022

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jun 8, 2022

Fixes #49

@tannewt tannewt mentioned this pull request Jun 8, 2022
Closed
bgilreath
bgilreath approved these changes Jun 8, 2022
View reviewed changes
Copy link

@bgilreath bgilreath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, however are the native network examples in the \examples folder consistent with the README changes? I am assuming the README and the actual example code should be consistent.

@tannewt
Copy link
Member Author

tannewt commented Jun 9, 2022

They should be. That's where I got the code from. :-)

FoamyGuy
FoamyGuy approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. tested each time setting method on PyPortal and ESP32-S2 respectively.

@FoamyGuy FoamyGuy merged commit f43a8e7 into adafruit:main Jun 13, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 14, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@77089da)
fd8e0eb 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 2.1.13 from 2.1.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#27 from mew-cx/mewcx_day_of_week_fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.5.11 from 1.5.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#26 from FoamyGuy/fix_day_names

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8563 to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8563#5 from FoamyGuy/fix_day_names

Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.11 from 0.5.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#19 from tekktrik/doc/add-docstrings

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.7 from 2.5.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#51 from tannewt/update_readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

+1 more reviewer

@bgilreath bgilreath bgilreath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native Networking Examples missing ssl and adafruit_requests in code from README.
3 participants
@tannewt @bgilreath @FoamyGuy