Skip to content

Fixing Pylint Short Names #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2023
Merged

Fixing Pylint Short Names #67

merged 2 commits into from
Mar 27, 2023

Conversation

jposada202020
Copy link
Contributor

closes #63 .

@jposada202020 jposada202020 requested a review from a team March 27, 2023 22:04
dhalbert
dhalbert requested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, how about adding cs to:

Adafruit_CircuitPython_BME280/.pylintrc

Line 282 in 5dee063

good-names=r,g,b,w,i,j,k,n,x,y,z,ex,ok,Run,_

"CS" is pretty universal. We don't expand "SDA" or "SCL", so I"m thinking "CS" would be ok instead of having to expand it.

@jposada202020
Copy link
Contributor Author

@dhalbert please see ed8aec4 . Thanks

@dhalbert dhalbert merged commit ce97999 into adafruit:main Mar 27, 2023
@jposada202020 jposada202020 deleted the fixing_short_names branch March 28, 2023 00:13
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 28, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d3c7302)
54f95cb 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.20 from 2.6.19:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#67 from jposada202020/fixing_short_names
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_ENS160 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ENS160#3 from rishi-a/readme-edit
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.3.18 from 3.3.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_SD#56 from jposada202020/fixing_short_names2
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library uses short argument names
2 participants
@jposada202020 @dhalbert