Skip to content

Fixed the operation mode reading issue #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 22, 2021
Merged

Fixed the operation mode reading issue #80

merged 5 commits into from
Apr 22, 2021

Conversation

GuenterQ
Copy link
Contributor

This pull request will fix the issue #79.

Only translate the lower 4 bits of the register OPR_MODE to the operation mode of the sensor.

@GuenterQ
Fixed the operation mode reading issue
0010961 
Only translate the lower 4 bits of the register OPR_MODE to the operation mode of the sensor.
@ladyada
Copy link
Member

ladyada commented Apr 18, 2021

thats a hex number

@GuenterQ
Copy link
Contributor Author

thats a hex number

Hello ladyada, sorry, I can't understand what you said. Could you please explain why all checks have failed?

Thank you.

@ladyada ladyada requested a review from evaherrada April 18, 2021 19:34
@jposada202020
Copy link
Contributor

@GuenterQ Checks failed as black is used to verify python code.
You can use this guide https://learn.adafruit.com/improve-your-code-with-pylint

Black failed as you are using unnecessary parenthesis here:

Adafruit_CircuitPython_BNO055/adafruit_bno055.py

Line 302 in 0010961

return ( self._read_register(_MODE_REGISTER) & 0x00001111 ) # Datasheet Table 4-2

and Black is reformatting the file to remove them. On doing that the CI will fail.

What Ladyada is referring to is that this 0x00001111 number looks more like an Hex number that a Binary number.

@GuenterQ
Copy link
Contributor Author

@GuenterQ Checks failed as black is used to verify python code.
You can use this guide https://learn.adafruit.com/improve-your-code-with-pylint

Black failed as you are using unnecessary parenthesis here:

Adafruit_CircuitPython_BNO055/adafruit_bno055.py

Line 302 in 0010961

return ( self._read_register(_MODE_REGISTER) & 0x00001111 ) # Datasheet Table 4-2

and Black is reformatting the file to remove them. On doing that the CI will fail.
What Ladyada is referring to is that this 0x00001111 number looks more like an Hex number that a Binary number.

Hello jposada202020! Thanks a lot!

I noticed the mistake I made. It has been modified.

@jposada202020
Copy link
Contributor

@GuenterQ just modify your line
to

return self._read_register(_MODE_REGISTER) & 0b00001111  # Datasheet Table 4-2

It will pass the CI, at least black 😃

@evaherrada
Copy link
Collaborator

@GuenterQ If you'd like to have this done automatically for you, we've got a guide on running black locally. https://learn.adafruit.com/improve-your-code-with-pylint/black

@jposada202020
Copy link
Contributor

@dherrada Changes were made by @GuenterQ could you take a look again . thanks :)

@ladyada ladyada merged commit 2f1ef83 into adafruit:master Apr 22, 2021
@GuenterQ GuenterQ mentioned this pull request Apr 22, 2021
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 30, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41b2432)
ac69e0e 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADXL34x to 1.11.8 from 1.11.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADXL34x#29 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 2.2.7 from 2.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#29 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_AS726x to 2.0.5 from 2.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS726x#16 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.3.1 from 5.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#81 from jposada202020/improving_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#80 from GuenterQ/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 2.1.8 from 2.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#22 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 2.1.7 from 2.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#23 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.9.0 from 3.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#62 from lesamouraipourpre/minimum_sentence_size
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.0.7 from 2.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ICM20X#12 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_L3GD20 to 2.3.5 from 2.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#22 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.1.9 from 2.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS2MDL#13 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS331 to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS331#3 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.10 from 5.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#68 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.10 from 1.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#16 from jposada202020/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#11 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#13 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.8 from 2.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#29 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.0.6 from 2.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#28 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.3.7 from 1.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#17 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPU6050 to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPU6050#16 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MSA301 to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MSA301#15 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.3.7 from 3.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#35 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC59711 to 2.0.0 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#17 from jposada202020/master
  > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#5 from s-light/multi
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4010 to 0.10.8 from 0.10.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#18 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4040 to 1.2.6 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4040#13 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.4.0 from 2.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#31 from jimbobbennett/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.5.0 from 1.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#46 from jposada202020/master
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#43 from jposada202020/raise_error_no_boundingbox
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#45 from FoamyGuy/simpletest_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.1.0 from 2.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#37 from jposada202020/new_example_circle
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#36 from empirical-dan/patch-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.9.2 from 1.9.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#36 from jposada202020/solving_parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@evaherrada evaherrada Awaiting requested review from evaherrada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuenterQ @ladyada @jposada202020 @evaherrada