Fix 2.6.0 lint #29
Merged
Fix 2.6.0 lint #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
I don't think I had a specific reason for the import order. I copied it out of the previously existing simpletest script and failed to remove that pylint disable in the displayio_simpletest one.
I am less sure whether it actually needs to be that way in that previously existing simpletest, perhaps it does because of the way it's doing to sys path stuff. It's also still got the same disable term in that file. I can experiment with that one a bit and see if we can fix the order and remove the disable from there as well.
This looks good to me thanks for resolving it!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 4, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.4.1 from 2.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#33 from jepler/remove-bad-whitespace-directive Updating https://github.com/adafruit/Adafruit_CircuitPython_MS8607 to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#2 from adafruit/dependency Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.3.1 from 3.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#84 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.2.2 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#29 from adafruit/tannewt-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#28 from ronfischler/set-changed-during-iteration-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.0 from 2.8.3: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#90 from kmatch98/bitmap_mutable Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.7 from 0.11.6: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#38 from tannewt/run_tests Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.2.3 from 3.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#47 from tannewt/run_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@FoamyGuy why was the order different in the displayio_simpletest to begin with? The disable has the wrong term so I'm surprised it worked at all.