Skip to content

Correcting readthedocs links #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2021
Merged

Correcting readthedocs links #313

merged 2 commits into from
May 11, 2021

Conversation

jposada202020
Copy link
Contributor

closes #307

@jposada202020 jposada202020 requested a review from a team May 11, 2021 12:21
anecdata
anecdata reviewed May 11, 2021
View reviewed changes
Copy link
Member

@anecdata anecdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new links all work. The mix of underscores and hyphens seems a little odd, but I assume that originates from each repo.

@jposada202020
Copy link
Contributor Author

Thanks @anecdata for reviewing, is the other way around this list is updated by the author when adding the library to the bundle.
Adabot will made a similar list link https://github.com/adafruit/Adafruit_CircuitPython_Bundle/blob/master/circuitpython_library_list.md and those documentation links are generated as you mention automatically

@jposada202020 jposada202020 merged commit 866af56 into adafruit:master May 11, 2021
@jposada202020 jposada202020 deleted the correcting_readthedocs_links branch May 11, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anecdata anecdata anecdata left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some doc links are incorrect
2 participants
@jposada202020 @anecdata