Skip to content

Update docs #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Update docs #15

merged 1 commit into from
Apr 28, 2024

Conversation

justmobilize
Copy link
Collaborator

@justmobilize justmobilize commented Apr 28, 2024

  • Added _global_key_by_socketpool to simplify code in connection_manager_close_all
  • Updated examples/connectionmanager_helpers.py to fix comments after variables changed in previous PR
  • Added better doc strings to methods

@justmobilize justmobilize marked this pull request as ready for review April 28, 2024 16:20
@justmobilize
Copy link
Collaborator Author

@dhalbert a quick follow-up

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit 2b5816d into adafruit:main Apr 28, 2024
1 check passed
@justmobilize justmobilize deleted the update-docs branch April 28, 2024 18:44
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 30, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ConnectionManager to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#15 from justmobilize/update-docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_IterTools to 2.1.1 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#25 from kbsriram/add-types-3
  > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#24 from kbsriram/add-types-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#63 from kbsriram/add-out-tests

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants