Different pool, different ConnectionManager #8
Conversation
|
@anecdata here's another one that would be awesome if you could test (with everything else in main) |
|
Since you easily have the ability to see where requests are coming from |
There was a problem hiding this comment.
Looks good! Test code and hardware photo here.
Adafruit CircuitPython 9.1.0-beta.1 on 2024-04-19; FeatherS3 with ESP32S3
(all other libraries standard latest except for this PR #8 version of ConnectionManager)
native wifi: UnexpectedMaker FeatherS3
ethernet: WIZnet 850io (W5500) "BFF"
esp32spi: Adafruit Airlift Breakout
Let it loop for a while, and verified that the router view of the HTTP sessions / IPv4 addresses matched the serial print sequence.
|
Looks good from a testing perspective, maybe someone wants to code review. |
|
@dhalbert once this is merged, I can take care of any conflicts and open up the 3x |
|
@justmobilize is this a bugfix version bump, or minor or major version bump, in terms of behavior? |
|
@dhalbert I would consider it |
Updating https://github.com/adafruit/Adafruit_CircuitPython_ConnectionManager to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#8 from justmobilize/different-pool-different-connection-manager > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#9 from justmobilize/wiznet5k-ssl > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#12 from justmobilize/test-updates > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#5 from FoamyGuy/fix_circup_instruction Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Update ConnectionManager, to support multiple different pools at the same time.
Testing steps:
Have a device with onboard WiFi and either a ESP32SPI or WIZNET5K
Connect both and make requests on both and see that they are from different devices.
You can also use a WIZNET5K create it's request session first, and then disconnect it and verify the other device still works.