Skip to content

Fix Pybadge no attribute error #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2019
Merged

Fix Pybadge no attribute error #12

merged 2 commits into from
Sep 5, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Sep 5, 2019

Joystick is not shared between the PyBadge and PyGamer. Sampling the joystick's center moved out of __init__ to init_hardware's pygamer-specific initialization.

Fixes #11

@brentru brentru added the bug Something isn't working label Sep 5, 2019
@brentru brentru requested a review from a team September 5, 2019 13:43
@brentru brentru mentioned this pull request Sep 5, 2019
Closed
tannewt
tannewt approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tannewt tannewt merged commit c2f9e3c into adafruit:master Sep 5, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 6, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@62c4c36)
b2e4b53 
Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#12 from brentru/fix-pybadge

Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#14 from jerryneedell/jerryn_refresh

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_IL0373, Adafruit_CircuitPython_IL0398, Adafruit_CircuitPython_IL91874, Adafruit_CircuitPython_SSD1608, Adafruit_CircuitPython_SSD1675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyBadge no attribute '_joystick_X_'
2 participants
@brentru @tannewt