Skip to content

Use debouncer to handle button analysis #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 3, 2019
Merged

Use debouncer to handle button analysis #3

merged 5 commits into from
Jul 3, 2019

Conversation

dastels
Copy link
Collaborator

@dastels dastels commented Jul 2, 2019

No description provided.

@dastels dastels requested a review from brentru July 2, 2019 20:29
brentru
brentru requested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dastels The response time to quick double-clicks seems slow and misses.

Could you add getter/setter methods called debounce_interval which increase the debouncer's interval property?

@dastels
Copy link
Collaborator Author

dastels commented Jul 2, 2019

Do we really want/need accessors for the debouncer interval, or is passing it as a constructor argument enough?

@brentru
Copy link
Member

brentru commented Jul 3, 2019

@dastels I think it's OK as a kwarg.

@brentru brentru merged commit 0c5cc05 into adafruit:master Jul 3, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 3, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@695f1dc)
1a05cf5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 2.0.0 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#11 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.0.0 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#5 from dastels/cursor
  > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#3 from dastels/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dastels @brentru