Skip to content

Remove secrets usage #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented Feb 24, 2025

Remove usage of secrets and more:

  1. change from using secrets.py to os.getenv
  2. switch from ESPSPI_WiFiManager to WiFiManager
  3. update pool, ssl_context setting to use adafruit_connection_manager like all the other examples

@justmobilize justmobilize marked this pull request as ready for review February 24, 2025 23:28
@justmobilize
Copy link
Contributor Author

@dhalbert there are 6 PRs that use ESPSPI_WiFiManager and are the largest user of secrets in examples. This is 1 of them

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure I didn't miss any of the key/password errors.

Co-authored-by: Dan Halbert <halbert@halwitz.org>
@justmobilize
Copy link
Contributor Author

@dhalbert you caught them all. Thank you. Not sure how that happened (I worked through all 6 together and this is the only one that happened in...)

@dhalbert dhalbert merged commit ca3e8b4 into adafruit:main Feb 25, 2025
1 check passed
@justmobilize justmobilize deleted the remove-secrets-usage branch February 25, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants