remove annotation and dial widgets from this repo. #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention in the original comment but I would consider #45 resolved once this is merged. The new Dial repo has been updated already to support the latest version of the |
|
@kattni to the best of my knowledge there are no guide or example usages of these two widgets outside of this repo. I grepped for both in the Learn guide repo and did not find any. As far as I know the only one of the widgets that are currently in this repo that did get used for a guide / example is the IconWidget which was used in the Stream Deck project. This PR doesn't remove IconWidget, my intention there is to ensure that the project bundler used by Learn system will be able to find it properly in it's new home before removing it from here so that the transition will be seamless to folks who are following that guide. |
kattni
approved these changes
Aug 23, 2021
|
Thanks! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 27, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1106 to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1106#5 from lesamouraipourpre/vertical-scroll Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.4.0 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#8 from lesamouraipourpre/vertical-scroll Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305 to 1.3.0 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305#13 from lesamouraipourpre/vertical-scroll Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.5.0 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#23 from lesamouraipourpre/vertical-scroll Updating https://github.com/adafruit/Adafruit_CircuitPython_OV2640 to 1.1.0 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_OV2640#12 from jerryneedell/jerryn_saola Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1322 to 1.2.0 from 1.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1322#12 from lesamouraipourpre/vertical-scroll Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.4.0 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#13 from lesamouraipourpre/vertical-scroll > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#12 from lesamouraipourpre/docs Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.0.3 from 8.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#132 from adafruit/dhalbert-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.12.0 from 1.11.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#47 from FoamyGuy/remove_dial_and_annotation Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.1.1 from 5.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_HID#79 from adafruit/tannewt-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_HID#76 from FoamyGuy/rename_gamepad_example Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#28 from Neradoc/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Annotation and Dial widgets and associated examples and documentation from this repo. These now have their own repos over in the circuitpython organization and they've both been added to the CircuitPython_Org bundle.
All of the code and documentation removed with this PR is now available in these respective repos:
https://github.com/circuitpython/CircuitPython_Org_DisplayIO_Dial
https://github.com/circuitpython/CircuitPython_Org_DisplayIO_Annotation
The other widgets that are in this repo currently will get removed as soon as they are setup in new repos in circuitpython org and added to that bundle.
This PR also updates the pylintrc file to the latest version that cookie-cutter now generates.