add pop_content() rename get_cell() to get_content() #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 6, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 3.0.0 from 2.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#99 from FoamyGuy/gridlayout_enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
pop_content()function to GridLayout. Previously there was no easy way to remove content from the grid once it was added. This functionality made the Set card game I am working on much easier to implement.I've also rename
get_cell()toget_content()which is a breaking change, we'll need to bump major version number if merged. In hindsight I think the add and get functions should have matched in the terms used in their names. "content" makes more sense than "cell" to me since what it gets or adds is the content that into the cell at the position specified.