Add type hints #14
Merged
Add type hints #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolves #8 |
FoamyGuy
requested changes
Jun 5, 2023
There was a problem hiding this comment.
Thanks for working on this @OptionalLion411!
One tweak that I think we need for the apple file is noted below.
Beyond that change this is looking good to me.
FoamyGuy
approved these changes
Jun 10, 2023
There was a problem hiding this comment.
The latest version is looking good to me. Thank you @OptionalLion411!
This was referenced Jun 10, 2023
Closed
Closed
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 11, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Notification to 0.9.15 from 0.9.14: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Notification#14 from OptionalLion411/main > Merge pull request adafruit/Adafruit_CircuitPython_Display_Notification#13 from tekktrik/dev/fix-packaging Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added type hints as mentioned by @FoamyGuy in #8.
Thanks for your review (@tekktrik) and with regards!