Type annotations in Display_text label library as a sample test for pylint and CI verifications #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s greater thant string length
|
As discussed: @hugodahl. Thanks let me know if you need help with anything :). |
hugodahl
reviewed
Feb 27, 2021
adafruit_display_text/label.py
Outdated
| @@ -140,7 +140,7 @@ def __init__( | |||
| if (anchored_position is not None) and (anchor_point is not None): | |||
| self.anchored_position = anchored_position | |||
|
|
|||
| def _create_background_box(self, lines, y_offset): | |||
| def _create_background_box(self, lines: int, y_offset: int): | |||
There was a problem hiding this comment.
Looks like one missed -> None for the return type. All other locations already appear to have it added
There was a problem hiding this comment.
Yes, I miss that one, thanks for pointing that out!
|
@hugodahl Thanks for the revision I made all the changes as suggested thanks for catching those up!!! |
|
This PR was superseded by #134 the type hints were included in that PR. The Tab replacement fix code was included with #132 Thanks for working on this @jposada202020! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during Saturday stream 2020-02-27 we want to include type annotations inside libraries code. Using this sample we want to verify CI behavior and possible solutions.