Skip to content

Api example inclusions #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2021
Merged

Api example inclusions #147

merged 3 commits into from
Mar 28, 2021

Conversation

jposada202020
Copy link
Contributor

This will allow to see all the example listed in the repository in the Readthedocs documentation

@jposada202020 jposada202020 added the documentation Improvements or additions to documentation label Mar 24, 2021
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes to examples.rst look good to me.

But this PR also seems to include some changes from #145. We can either wait until that PR is ready to merge and then bring this one in. Or if you like you could change this PR (or make a new one) that includes the examples.rst changes by itself and we could likely merge that sooner.

@jposada202020
Copy link
Contributor Author

@FoamyGuy thanks for reviewing, I think we could wait. this is an improvement and I will made the changes for #145 tonight :)

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @jposada202020!

@FoamyGuy FoamyGuy merged commit a94b7d8 into adafruit:master Mar 28, 2021
@jposada202020
Copy link
Contributor Author

@FoamyGuy Thank you for reviewing :)

@jposada202020 jposada202020 deleted the api_example branch March 28, 2021 22:11
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 29, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#13 from dhalbert/setup-packages

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.18.1 from 2.17.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#147 from jposada202020/api_example
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#145 from jposada202020/master
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants