Skip to content

Added anchor_point and anchor_position options as parameters #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2020

Conversation

kmatch98
Copy link
Contributor

This is to resolve #44

This updates the init parameters to allow the anchor_point and anchor_position to be set when the label is instanced.

Note: Somehow the diff shows many more changes than expected. Let me know if I need to update my fork to clarify these changes. But to do so I will need to educate myself on exactly how to do the appropriate git incantations.

@kmatch98
Copy link
Contributor Author

Thanks to tannewt I was able to clear up the git-related "missing commits" issue by merging the master into my branch.

I added two local variables to the __init__ function (anchor_point and anchored_position), so pylint gave an error about "too-many-locals". I added pylint: disable=too-many-locals to ignore this error.

I you think I should resolve that, let me know and I'll see if I can figure out how to fix it.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit d855e29 into adafruit:master Jul 24, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 28, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.2 from 3.10.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#85 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 2.3.0 from 2.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#29 from gphi/measure-raw-sensor-data

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.8.0 from 2.7.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#74 from FoamyGuy/no_bitmap_when_background_none
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#73 from kmatch98/anchor_params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Awkward usage of Label with x,y, then anchor_point and anchored_position
2 participants