I commited some updates to resolve some of the pylint errors on bitmap_label but over-rode some of them. Also, the examples retain some pylint errors. Please let me know whether I need to resolve these.

I updated the getters and setters to match label.py.

I have a couple of pylint errors that I'm not sure how to resolve. These are three setters (font, text, line_spacing) that only return errors. I suspect it is flagging these functions because they don't use the input variables or any references to self. Any suggestions on how to solve the pylint errors?

iMac-86:adafruit_display_text margaret$ pylint bitmap_label.py
************* Module bitmap_label
bitmap_label.py:424:4: R0201: Method could be a function (no-self-use)
bitmap_label.py:465:4: R0201: Method could be a function (no-self-use)
bitmap_label.py:476:4: R0201: Method could be a function (no-self-use)

Here is the code I used to verify the operation of the getters/setters:

gc.collect()
label_start_memory = gc.mem_free()
start_time = time.monotonic()

bmap_label = label.Label(
    font=terminalio.FONT,
    text=my_string,
    color=0xFFFFFF,
    max_glyphs=len(my_string),
    background_color=0xFF0000,
    padding_bottom=0,
    padding_left=0,
    padding_right=0,
    padding_top=0,
    background_tight=False,
    x=10,
    y=30,
    line_spacing=1.25,
    scale=my_scale,
)
end_time = time.monotonic()

gc.collect()
label_end_memory = gc.mem_free()

bmap_group = displayio.Group(max_size=1)  # Create a group for displaying
bmap_group.append(bmap_label)


print("***")
print("{} memory used: {}".format(version, label_start_memory - label_end_memory))
print("{} time to process: {} seconds".format(version, end_time - start_time))
display.auto_refresh = True

display.show(bmap_group)

print("bounding_box: {}".format(bmap_label.bounding_box))
import time
time.sleep(1)
print('color: {}'.format(bmap_label.color))
bmap_label.color=0xFFFF00
time.sleep(1)
print('background_color: {}'.format(bmap_label.background_color))
bmap_label.background_color=0x00FFFF
time.sleep(1)
print('background_color: {}'.format(bmap_label.background_color))
bmap_label.background_color=0x0000FF
time.sleep(1)

print('text: {}'.format(bmap_label.text))
#bmap_label.text='new text' # should cause an error

print('current linespacing: {}'.format(bmap_label.line_spacing))
#bmap_label.line_spacing=3 # should cause an error
print('font: {}'.format(font))
#bmap_label.font=terminalio.FONT # should cause an error
time.sleep(1)

print('anchored_position: {}'.format(bmap_label.anchored_position))
bmap_label.anchored_position=(320/2, 240/2)
print('anchored_position: {}'.format(bmap_label.anchored_position))
time.sleep(1)

print('anchor_point: {}'.format(bmap_label.anchor_point))
bmap_label.anchor_point=(0.5,0.5)
time.sleep(1)

print('anchored_position: {}'.format(bmap_label.anchored_position))
bmap_label.anchored_position=(320/2, 240/2)
print('anchored_position: {}'.format(bmap_label.anchored_position))
time.sleep(1)

print('anchor_point: {}'.format(bmap_label.anchor_point))
bmap_label.anchor_point=(0,0)
print('anchor_point: {}'.format(bmap_label.anchor_point))
time.sleep(1)


print('anchor_point: {}'.format(bmap_label.anchor_point))
bmap_label.anchor_point=(0.5,0.5)
time.sleep(1)




while True:
    pass

I think it's okay to add the pylint ignore inside of those three functions to disable the no-self-use check.

Although I'm also curious how hard it would be (or if there is any downside) to allow those properties to be mutable by having them call _place_text() again. I'm going to try it out and see if I can get it working.

Good point maybe if the bitmap is recreated then it will should work fine. Just have to be sure it releases the previous bitmap so it can get garbage collected. Keep me posted on what you find.

I got dug into it some and I see it's going to be a bit more difficult that I was thinking to make them mutable at least for text.

I think we will need to recreate the tilegrid too possibly, and do some calculations to figure out the correct size again. Which will mean that we need a few of the parameters to be stored as class variables so that they can be accessed outside of __init__()

I think it's a good goal to make them mutable at some point if we can, but I'm not sure it's worth holding up this PR for it.

For now I do think it's okay to add the pylint ignores since those methods currently are only provided for API matching and to throw the error letting the user know that they aren't mutable. They don't need to use self for anything in order to do that.

Ok, I just pushed with the pylint: disable=no-self-use to clear the pylint error.
I think I covered all your previous corrections, please let me know what else you find.

Future: Maybe this should be an issue

I agree that making it mutable will take some time. I've never done anything with actively freeing up instances, so that will be new ground. But I'll spend my time working on getting the bitmap.blit function cleaned up before returning to this.

I merged your last changes and all passed the checks. I like the quote on the comparison example.

I think I resolved all of your Review changes that you requested, but double check. Otherwise, I think this is good to go.

I hunted for the Strange glyph loading memory usage and remembered why.

For determining the ascender/descender height, It checks the max dimensions of several glyphs: M, j, space, and ‘ apostrophe. So it’s best to load these four glyphs are loaded in the load_glyphs statement. I will update the examples tomorrow to add the apostrophe.

I looked over the current version tonight and it looks good to me. I'll mark it approve after you get that last change in and we can see if we get any other feedback prior to merging

Ok, I just updated the examples and passed the checks. Let me know what else you find that needs updates.

Future enhancements:

• Make bitmap_label type more mutable
• If bitmap.blit function is merged in the CircuitPython core, then update bitmap_label.py to utilize this faster copy function

Awesome. Thanks for your help working on this!