Fix some white spaces and empty lines bugs #10
Conversation
Some issues ares detected when - There are white spaces before and/or after when send press multiple keys - There is a empty line at the end of the file (index out of bound) - When default delay is modified, single or multiple key remain pressed during default delay period. 144: Fix white spaces after line 189: Prevent from key still pressed when default delay is more than zero. 202: Prevent error index out of bound whet read last line 203: Fix
Fix some issues
|
Any advice of how address the precheck error in TEST task?
|
|
You can fix the CI errors by using |
There was a problem hiding this comment.
I don't understand the first of the issues you mentioned:
144: Fix white spaces after line
I tested a few different duckyscript examples with whitespace at the end of lines. Everything seems to behave as expected as far as I could tell.
Do you have some specific script code in mind and a description of what problem you encountered when it executed?
I noticed that the proposed change for this fix strips whitespace from the end of STRING commands so for instance the duckyscript code: STRING Hello will lose all of the whitespace at the end of it even though the user did put those spaces into the code.
For now I think it's best if we revert this specific fix and look at the others on their own merits.
We can always open up a new PR to add this fix if there is a specific case that it fixes that I'm missing (and ideally if we can get it not to ignore literal spaces added in the code if they're intentional.)
There was a problem hiding this comment.
I tested this successfully on a Feather S2 TFT.
I was able to replicate the issue and confirm the fixes for these:
189: Prevent from key still pressed when default delay is more than zero.
202: Prevent error index out of bound whet read last line
203: Fix an error when press multiples key that skip the next execution line.
For this one:
144: Fix white spaces after line
I could not replicate any issues that I was able to notice. And I found that the included fix can cause intentional whitespace at the end of STRING commands to be stripped.
This PR Branch would not allow me to commit to it so I've created #11 starting from this branch with fixes for code format so we can get this merged.
Some issues are detected when:
144: Fix white spaces after line
189: Prevent from key still pressed when default delay is more than zero.
202: Prevent error index out of bound whet read last line
203: Fix an error when press multiples key that skip the next execution line.