Change argument name to *_dio #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Jul 7, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 8, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 1.3.5 from 1.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#21 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_DymoScale to 2.0.0 from 1.1.9: > Merge pull request adafruit/Adafruit_CircuitPython_DymoScale#15 from tekktrik/dev/change-argname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the argument name from
units_pintounits_dio, since it takesmicrocontroller.Pin, whereas the other argumentdata_pinreally does takemicrocontroller.Pin. This would be a breaking change, but I found no dependent libraries, and the only Learn Guide example uses the arguments positionally.Resolves #14.