Skip to content

Example fails with OverflowError: value must fit in 1 byte(s) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrmcwethy opened this issue May 19, 2019 · 5 comments
Closed

Example fails with OverflowError: value must fit in 1 byte(s) #19

mrmcwethy opened this issue May 19, 2019 · 5 comments

Comments

@mrmcwethy
Copy link
Collaborator

mrmcwethy commented May 19, 2019

I am using CP 4 rc3. I was told there was a recent change that checks on assignment for high-order bits truncation. The EPD library used to do & 0xFF when assigning to a buffer item, but that was removed. I think it is now really needed.

epd.py lines 131, 132
mcp_sram.py lines 74,75,84,85,113,114
all need & 0xFF added.

I am ready to fix this, if it is truely a bug.

@makermelissa
Copy link
Collaborator

Hi. Would you like to submit a PR?

@mrmcwethy
Copy link
Collaborator Author

mrmcwethy commented May 19, 2019 via email

mrmcwethy added a commit to mrmcwethy/Adafruit_CircuitPython_EPD that referenced this issue May 19, 2019
@mrmcwethy
Copy link
Collaborator Author

mrmcwethy commented May 20, 2019 via email

@makermelissa
Copy link
Collaborator

Thanks, I'm testing it. :)

makermelissa added a commit that referenced this issue May 20, 2019
Fix for issue #19 OverflowError:  value must fit in 1 byte(s)
@makermelissa
Copy link
Collaborator

Fixed with #20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants