UDP Client using socket #127
Conversation
There was a problem hiding this comment.
I tested this
Adafruit CircuitPython 6.2.0-beta.2 on 2021-02-11; Raspberry Pi Pico with rp2040Using an Airlift Module
with a little modified testing code as presented in PR #128 aca519f
Test Code
# SPDX-FileCopyrightText: 2021 Adafruit Industries
# SPDX-License-Identifier: MIT
import struct
import time
import board
from digitalio import DigitalInOut
from adafruit_esp32spi import adafruit_esp32spi
import adafruit_esp32spi.adafruit_esp32spi_socket as socket
import busio
# Get wifi details and more from a secrets.py file
try:
from privados import secrets
except ImportError:
print("WiFi secrets are kept in secrets.py, please add them there!")
raise
TIMEOUT = 5
# edit host and port to match server
HOST = "pool.ntp.org"
PORT = 123
NTP_TO_UNIX_EPOCH = 2208988800 # 1970-01-01 00:00:00
# PyPortal or similar; edit pins as needed
esp32_cs = DigitalInOut(board.GP5)
esp32_ready = DigitalInOut(board.GP6)
esp32_reset = DigitalInOut(board.GP7)
spi = busio.SPI(board.GP2, board.GP3, board.GP4)
esp = adafruit_esp32spi.ESP_SPIcontrol(spi, esp32_cs, esp32_ready, esp32_reset)
# connect to wifi AP
esp.connect(secrets)
# test for connectivity to server
print("Server ping:", esp.ping(HOST), "ms")
# create the socket
socket.set_interface(esp)
socketaddr = socket.getaddrinfo(HOST, PORT)[0][4]
s = socket.socket()
s.settimeout(TIMEOUT)
print("Sending")
s.connect(socketaddr, esp.UDP_MODE)
packet = bytearray(48)
packet[0] = 0b00100011 # Not leap second, NTP version 4, Client mode
s.send(packet, esp.UDP_MODE)
print("Receiving")
packet = s.recv(48)
seconds = struct.unpack_from("!I", packet, offset=len(packet) - 8)[0]
print("Time:", time.localtime(seconds - NTP_TO_UNIX_EPOCH))Result
Server ping: 150 ms Sending Receiving Time: struct_time(tm_year=2021, tm_mon=3, tm_mday=18, tm_hour=22, tm_min=54, tm_sec=46, tm_wday=3, tm_yday=77, tm_isdst=-1)
Looks good to me
|
@brentru Do you see any issues with adding the kwarg to |
|
I do have an issue with this PR - the Instead, like CPython, within the |
|
I can look in to that. I mirrored the way |
|
Re-tested with (modified) UDP client. Regression tested with TCP client and HTTP client (Requests). |
to match latest UDP client PR #127 commit
There was a problem hiding this comment.
This looks good, I had to modify @jposada202020 's NTP code to reflect PR #129
# SPDX-FileCopyrightText: 2021 Adafruit Industries
# SPDX-License-Identifier: MIT
import struct
import time
import board
from digitalio import DigitalInOut
from adafruit_esp32spi import adafruit_esp32spi
import adafruit_esp32spi.adafruit_esp32spi_socket as socket
import busio
# Get wifi details and more from a secrets.py file
try:
from secrets import secrets
except ImportError:
print("WiFi secrets are kept in secrets.py, please add them there!")
raise
TIMEOUT = 5
# edit host and port to match server
HOST = "pool.ntp.org"
PORT = 123
NTP_TO_UNIX_EPOCH = 2208988800 # 1970-01-01 00:00:00
# If you are using a board with pre-defined ESP32 Pins:
esp32_cs = DigitalInOut(board.ESP_CS)
esp32_ready = DigitalInOut(board.ESP_BUSY)
esp32_reset = DigitalInOut(board.ESP_RESET)
spi = busio.SPI(board.SCK, board.MOSI, board.MISO)
esp = adafruit_esp32spi.ESP_SPIcontrol(spi, esp32_cs, esp32_ready, esp32_reset)
# connect to wifi AP
esp.connect(secrets)
# test for connectivity to server
print("Server ping:", esp.ping(HOST), "ms")
# create the socket
socket.set_interface(esp)
socketaddr = socket.getaddrinfo(HOST, PORT)[0][4]
s = socket.socket(type=socket.SOCK_DGRAM)
s.settimeout(TIMEOUT)
print("Sending")
s.connect(socketaddr, esp.UDP_MODE)
packet = bytearray(48)
packet[0] = 0b00100011 # Not leap second, NTP version 4, Client mode
s.send(packet)
print("Receiving")
packet = s.recv(48)
seconds = struct.unpack_from("!I", packet, offset=len(packet) - 8)[0]
print("Time:", time.localtime(seconds - NTP_TO_UNIX_EPOCH))
Output:
code.py output:
Server ping: 20 ms
Sending
Receiving
Time: struct_time(tm_year=2021, tm_mon=3, tm_mday=26, tm_hour=15, tm_min=27, tm_sec=45, tm_wday=4, tm_yday=85, tm_isdst=-1)
Tested on Adafruit CircuitPython 6.2.0-beta.4 on 2021-03-18; Adafruit PyPortal with samd51j20
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.9 from 3.5.8: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#129 from adafruit/anecdata-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#127 from anecdata/udp_client
UDP Client was previously possible using
espcalls directly. This change allows UDP Client at thesocketlevel.