Static ip hostname and dns #159
Conversation
…e esp32spi interface as the esp32SPI interface supports this
There was a problem hiding this comment.
After adjusting pins to match all-in-one Airlift device (PyPortal), and correcting the double-encoding, example successfully changes IP config, hostname, and DNS config. Results verified on router, and device with modified configs operates successfully on the network. Code changes LGTM. Did not test the UDP part of the example.
There was a problem hiding this comment.
Retested example. hostname shows in router. IP address initially comes from DHCP as expected, then changed to static when example sets IP config. After setting DNS config to addresses not used elsewhere on my network, confirmed that config is getting used by viewing sessions in the router. NINA (Arduino) seems to use the first DNS address only, unless it fails, then it times out and tries the second DNS address. UDP and other comms operated fine in testing with the static IP config and custom DNS config.
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 4.1.0 from 4.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#159 from Neradoc/staticIP-hostname-and-dns Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8563 to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8563#4 from tekktrik/doc/add-typing > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.12 from 3.10.11: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#101 from makermelissa/master > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_Debouncer to 2.0.0 from 1.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#38 from Neradoc/better-button-class Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 0.1.2 from 0.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#1 from askpatrickw/fix-install-commmand Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.1.0 from 2.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#39 from Neradoc/setup-layout-on-init Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 2.1.9 from 2.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#83 from UnicycleDumpTruck/add-type-annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.7.4 from 1.7.3: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#42 from tekktrik/doc/add-typing > Fixed readthedocs build > Consolidate Documentation sections of README
Picking up #141
Adding documentation to the new methods.
And documentation fixes all over the library (was missing an empty line before parameters in some methods).
(Also removed a few line returns at the start of docstrings to stay below 1000 lines for pylint)