Skip to content

fix esp32spi_aio_post.py -- remove bytes() #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2019
Merged

fix esp32spi_aio_post.py -- remove bytes() #30

merged 1 commit into from
Mar 17, 2019

Conversation

jerryneedell
Copy link
Contributor

remove use of bytes() for the header strings

@jerryneedell jerryneedell requested review from makermelissa and a team March 15, 2019 20:22
@makermelissa
Copy link
Collaborator

I’ll test tonight. I don’t have my board with me at the moment.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It tested fine, but I'm wondering if we should make the PyPortal parameters the default?

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm going to approve it and leave it up to you about which ones to make the default. I suppose probably leave it like it is so it matches.

@jerryneedell jerryneedell merged commit c2e0fd2 into adafruit:master Mar 17, 2019
@jerryneedell jerryneedell deleted the jerryn_aio_post branch March 17, 2019 18:30
@jerryneedell
Copy link
Contributor Author

@makermelissa I left it as is for now since the guides that use it tell the user to change it for PyPortal.

@ladyada
Copy link
Member

ladyada commented Mar 17, 2019

thanks folks!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 23, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#14 from caternuson/iss13

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.3.5 from 1.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#30 from jerryneedell/jerryn_aio_post

Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#16 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.3.1 from 2.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#14 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#8 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#7 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_TPA2016, Adafruit_CircuitPython_Display_Button, Adafruit_CircuitPython_Display_Shapes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants