Adding library, example and docs #1
Conversation
|
hihi @makermelissa - since you've worked on touch drivers before would you mind reviewing this? |
docs/conf.py
Outdated
| "adafruit_bus_device", | ||
| "adafruit_register", |
There was a problem hiding this comment.
I don't think these 2 lines are necessary here if they are libraries. Especially since you already have them under requirements.
There was a problem hiding this comment.
thanks @makermelissa - i tried removing them but it caused CI to fail so i think they are needed
There was a problem hiding this comment.
Hmm, the error is odd and that adding it there fixed it. Neither of the 2 previous touch libs needed an autodoc_mock_imports and it's really only used for adding internal modules that haven't been added to Blinka.
- https://github.com/adafruit/Adafruit_CircuitPython_CST8XX/blob/main/docs/conf.py
- https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch/blob/main/docs/conf.py
I'll see if I can find more info on the error.
There was a problem hiding this comment.
Can you try removing all of the autodoc_mock_imports? Really, none of them should be needed.
There was a problem hiding this comment.
ah, that did it. thank you!
Adding library, example and docs for the FT5336 touch driver