Skip to content

Update the pre-commit and github workflow to move pylint to pre-commit. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2021
Merged

Update the pre-commit and github workflow to move pylint to pre-commit. #59

merged 2 commits into from
May 13, 2021

Conversation

lesamouraipourpre
Copy link
Contributor

Also, disable duplicate-code check in examples.

@ladyada ladyada requested a review from evaherrada March 1, 2021 22:54
evaherrada
evaherrada requested changes Mar 1, 2021
View reviewed changes
@evaherrada
Copy link
Collaborator

@lesamouraipourpre Can you check that the changes you're making are the same as the ones in the place I linked? I think they are, but I just wanted you to check as well before I merge.

@lesamouraipourpre
Copy link
Contributor Author

@lesamouraipourpre Can you check that the changes you're making are the same as the ones in the place I linked? I think they are, but I just wanted you to check as well before I merge.

Yes, it was essentially a copy-and-paste to add the pylint sections.

Confirmed with:

diff cookiecutter-adafruit-circuitpython/{%\ if\ cookiecutter.library_prefix\ %}{{\ cookiecutter.library_prefix\ |\ capitalize\ }}{%\ endif\ %}CircuitPython{{\ cookiecutter.library_name}}/.pre-commit-config.yaml Adafruit_CircuitPython_GPS/.pre-commit-config.yaml

@jposada202020
Copy link

@dherrada :) according to what I read I guess we could merge this change. let me know. Thanks!

@evaherrada
Copy link
Collaborator

Sweet. Looks good. @jposada202020 Thanks for the reminder on this one

@evaherrada evaherrada merged commit e6cef05 into adafruit:master May 13, 2021
@jposada202020
Copy link

No problem :) @dherrada

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 14, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@3dfaf62)
04c10c9 
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.9.1 from 3.9.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#66 from lesamouraipourpre/rmc
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#59 from lesamouraipourpre/pylint-yaml

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.12.1 from 2.12.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#67 from eliotg/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.15.2 from 1.15.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#55 from deshipu/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evaherrada evaherrada Awaiting requested review from evaherrada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesamouraipourpre @evaherrada @jposada202020