Skip to content

Remember LED status #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Remember LED status #113

merged 1 commit into from
Mar 20, 2023

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Mar 16, 2023

.last_received_report() is not persistent anymore, due to adafruit/circuitpython#6767. Remember what it returns.

@andreasbrett This should fix your issue. Please test if you are able to. Thanks.

@dhalbert dhalbert requested a review from a team March 16, 2023 19:33
@dhalbert
Copy link
Collaborator Author

@andreasbrett Would you like to test this?

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Thank you!

@dhalbert dhalbert merged commit b93f918 into adafruit:main Mar 20, 2023
@dhalbert dhalbert deleted the fix-led-status branch March 20, 2023 21:31
@andreasbrett
Copy link

andreasbrett commented Mar 20, 2023

@andreasbrett Would you like to test this?

I'm sorry - I missed your comments and only noticed this now.

@dhalbert
Copy link
Collaborator Author

@andreasbrett Would you like to test this?

I'm sorry - I missed your comments and only noticed this now.

I spelled your username wrong, sorry (I just corrected it.) But I think this should fix your problem.

@dhalbert
Copy link
Collaborator Author

This fix is in the release I just made: 5.3.4

@andreasbrett
Copy link

@andreasbrett Would you like to test this?

tested and works. thank you very much for fixing this quickly!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 21, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L1X to 1.1.10 from 1.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L1X#15 from jposada202020/adding_version_metadata
  > Add upload url to release action

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 2.4.0 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#97 from BiffoBear/shorter_socket_exit_timeout
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#99 from BiffoBear/fix_out_of_sockets
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#101 from BiffoBear/fix_socket.close()_behaviour

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.3.4 from 5.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#113 from dhalbert/fix-led-status
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adafruit_hid.keyboard.Keyboard.led_on only returns True once only
3 participants