Do not wait for USB for non-USB HID devices #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
approved these changes
Nov 29, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 30, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 6.0.2 from 6.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_HID#122 from dhalbert/ble-device-no-wait Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121.
find_device()was waiting for USB to be connected even if the device was not a USB device. Wait only if a USB device was found.In the long run, maybe the dependency on USB should be decoupled from
find_device(). In that case, there should be some other way, maybe explicit or implicit, of waiting for the HID transport channel to be ready.Also there could be an addition to
circuitpython_typingfor duck-typing an HID device.I tested this on a CLUE.